> I'm really reluctant to add one-trick-pony utility macros like this because 
> over time they tend to become liabilities one way or the other, and have 
> other issues.

Good.

> 
> Manipulating compiler flags is a very common need indeed and could use some 
> help from rpm, but that need is not limited to %optflags, there are various 
> other similar things as well and I certainly don't want separate macros for 
> updating %build_cflags, %build_cxxflags, %build_ldflags and so on.

To be honest, I'm not much familiar with `m4` language and how `rpm` works. Can 
you please help me how should such macro look like? Should it take the variable 
name as a first argument?

> 
> I'd be more inclined to consider a generic utility or macro primitive that 
> helps in these kind of tasks. Also, it's worth considering whether the flags 
> be stored in a more manipulation friendly manner in the first place.

I'm open for a better-defined API. Can you help me with that as well?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/815#issuecomment-521206621
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to