Updated the pull request:
- about the dbiNew() call that cannot fail: this is copied from the other
backends. I currently left it untouched so that a different commit can clean up
all the backends.
- about using NULL: I think NULL is some leftover from the old K&R days and
should be avoided. Saying to use NULL as return value is like saying you need
to use `return 0ULL` in functions that return unsigned long longs. Anyway, I've
changed the code so that NULL is used.
- about that `goto exit` idiom: I don't like it so I only use it if it really
reduces the lines of code.
- about the dbi allocation leak: yes, that was a bug. Fixed.
- the ro backend is now also enabled in the ci.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/980#issuecomment-573666097
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
