gordonmessmer commented on this pull request.


> +        else:
+            rpm_epoch = ''
+        while self.version[-1] == 0:
+            self.version.pop()
+        rpm_version = '.'.join(str(x) for x in self.version)
+        if self.pre:
+            rpm_suffix = '~%s' % ''.join(str(x) for x in self.pre)
+        elif self.post:
+            rpm_suffix = '^post%d' % self.post[1]
+        else:
+            rpm_suffix = ''
+        return '%s%s%s' % (rpm_epoch, rpm_version, rpm_suffix)
+
+def convert_compatible(name, operator, version_id):
+    if version_id.endswith('.*'):
+        return 'Invalid version'

The expression is invalid, and will cause setup.py to fail, so I'm reasonably 
certain that we'd never see it, but exiting with an error code is probably a 
good idea anyway.

(rpm would otherwise require a package named "Invalid version")

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1015#discussion_r369608817
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to