mlschroe commented on this pull request.
> @@ -514,6 +514,22 @@ static ARGV_t runCmd(const char *cmd,
return output;
}
+static ARGV_t runCall(const char *cmd,
+ const char *buildRoot, const char *fn)
+{
+
+ ARGV_t output = NULL;
+ char *fullcmd = rstrscat(NULL, "%{", cmd, " ", "%{?buildroot:buildroot/}",
fn, "}", NULL);
This doesn't work for file names like `foo}bar` or `foo%%bar`. To make that
bulletproof, you'd need a `rpmMacroExpandParametric(rpmMacroContext mc, const
char *n, ARGV_t argv)` function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1053#pullrequestreview-354340714_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
