@jessorensen commented on this pull request.


> @@ -430,6 +438,10 @@ typedef enum rpmSigTag_e {
     RPMSIGTAG_SHA256   = RPMTAG_SHA256HEADER,
     RPMSIGTAG_FILESIGNATURES           = RPMTAG_SIG_BASE + 18,
     RPMSIGTAG_FILESIGNATURELENGTH      = RPMTAG_SIG_BASE + 19,
+    RPMSIGTAG_VERITYSIGNATURES         = RPMTAG_SIG_BASE + 20,
+    RPMSIGTAG_VERITYSIGNATURELENGTH    = RPMTAG_SIG_BASE + 21,
+    RPMSIGTAG_VERITYSIGNATUREALGO      = RPMTAG_SIG_BASE + 22,
+    RPMSIGTAG_VERITYSIGNATUREBLKSZ     = RPMTAG_SIG_BASE + 23,

Thanks for the feedback, much appreciated!

So first question, you are suggesting I move the tags to the range of 
RPMTAG_SIG_BASE like this - just want to make sure I got it right:
RPMTAG_SHA256HEADER             = RPMTAG_SIG_BASE+17,   /* s */

With regard to the different tags, then for the signature length, it depends on 
the key used and the algorithm. Are you suggesting we calculate the length of 
the signature from the length of the signature array and divide it by the 
number of entries?

Block size is a little tricky, as it depends on the file system block size, 
which depending on the file system is either fixed or page size. I was planning 
on adding option parameters to rpmsign allowing someone to specify them for the 
case they want to build rpms on one platform to be installed on another 
platform.

I was operating under the assumption that as long as the tag was an integer, it 
wouldn't take up too much space and not be a big deal?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1203#discussion_r431332533
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to