@jessorensen commented on this pull request.


> @@ -166,8 +184,9 @@ int main(int argc, char *argv[])
        argerror(_("no arguments given"));
     }
 
-#ifdef WITH_IMAEVM
-    if (fileSigningKey && !(sargs.signflags & RPMSIGN_FLAG_IMA)) {
+#if defined(WITH_IMAEVM) || defined(WITH_FSVERITY)
+    if (fileSigningKey &&
+       !(sargs.signflags & (RPMSIGN_FLAG_IMA | RPMSIGN_FLAG_FSVERITY))) {
        argerror(_("--fskpath may only be specified when signing files"));

I like this and introduced a flags_sign_files() helper. It was applicable in 
two places, so it made the code a lot easier to read.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1203#discussion_r431434364
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to