@jessorensen commented on this pull request.
> + digest_hex = pgpHexStr(digest->digest, digest->digest_size);
+ rpmlog(RPMLOG_DEBUG, _("file(size %li): %s: digest(%i): %s, idx %i\n"),
+ file_size, rpmfiFN(fi), digest->digest_size, digest_hex,
+ rpmfiFX(fi));
+
+ free(digest_hex);
+
+ memset(&sig_params, 0, sizeof(struct libfsverity_signature_params));
+ sig_params.keyfile = key;
+ sig_params.certfile = cert;
+ if (libfsverity_sign_digest(digest, &sig_params, &sig, sig_size)) {
+ rpmlog(RPMLOG_DEBUG, _("failed to sign digest\n"));
+ goto out;
+ }
+
+ sig_hex = pgpHexStr(sig, *sig_size);
Good point, I used IMA file signatures as a reference since it's the closest in
behavior to what I need. Switching to base64 makes a ton of sense though, so
I'll update the code to use that instead, and push an update when I have that
working.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1203#discussion_r431450635_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
