@jessorensen commented on this pull request.


> @@ -15,6 +15,7 @@
 
 #include <rpm/rpmlog.h>
 #include <rpm/rpmmacro.h>
+#include <rpm/rpmver.h>

This change breaks the build for me here:

```
libtool: compile:  gcc -DHAVE_CONFIG_H -I.. -I.. -I../include/ -I../misc 
-DRPMCONFIGDIR=\"/usr/lib/rpm\" -DLOCALSTATEDIR=\"/var\" -I../luaext/ 
-D_REENTRANT -Wall -Wpointer-arith -Wmissing-prototypes -Wstrict-prototypes 
-fno-strict-aliasing -fstack-protector -Wempty-body -g -O2 -MT expression.lo 
-MD -MP -MF .deps/expression.Tpo -c expression.c  -fPIC -DPIC -o 
.libs/expression.o
expression.c:18:10: fatal error: rpm/rpmver.h: No such file or directory
   18 | #include <rpm/rpmver.h>
      |          ^~~~~~~~~~~~~~
compilation terminated.
```

Should it be "rpmio/rpmver.h" ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1233#pullrequestreview-423736825
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to