@pmatilai commented on this pull request.


> +    return RPMRC_OK;
+}
+
+static rpmRC dbus_announce_tsm_pre(rpmPlugin plugin, rpmts ts)
+{
+    int rc;
+
+    rc = open_dbus(plugin, ts);
+    if (rc != RPMRC_OK)
+       return rc;
+    return send_ts_message(plugin, "StartTransaction", ts, RPMRC_OK);
+}
+
+static rpmRC dbus_announce_tsm_post(rpmPlugin plugin, rpmts ts, int res)
+{
+    return send_ts_message(plugin, "CompleteTransaction", ts, res);

This is perhaps in the bike-shedding department, but "complete" by definition 
seems to indicate success, whereas this can have an error condition as well. So 
maybe "EndTransaction" would be closer to pairing with Start in these context.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#pullrequestreview-427924424
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to