Oh, sorry, I've forgot to update "status" here.

We can't merge a patch that fails the CI tests - this fails because fsverity is 
enabled in the CI but the library doesn't exist in Fedora 32. Hardly surprising 
as the library version isn't even released upstream AFAICS. That can be worked 
around by not enabling it in the CI, but I'm also not going to merge a patch 
I've never seen compile (and I haven't gotten around to build from upstream 
yet, although I did notice the library thing has been merged). I'd prefer to 
see an upstream release of fsverity library before merging and optimally, said 
version in Fedora >= 32 so we could enable it in CI, but I do realize there 
could be other incompatibilities preventing the latter from occurring so that 
can't be a hard requirement.

Speaking of enabling it in configure, I just noticed that it doesn't actually 
check for fsverity presence in configure, so if enabled but missing it'll fail 
in middle of compilation instead of configure time as it should. So there's a 
minor tweak that'll be needed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1203#issuecomment-643195027
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to