@dmnks commented on this pull request.


>  
        if (gpg_path && *gpg_path != '\0')
            (void) setenv("GNUPGHOME", gpg_path, 1);
 
+       if (tty)
+           setenv("GPG_TTY", tty, 0);
+       else if (!getenv("GPG_TTY"))
+           rpmlog(RPMLOG_WARNING, _("Could not set GPG_TTY to stdin: %m\n"));

Yeah, this was a bit sloppy, I agree. The `getenv()` test was supposed to 
handle the case where the automatic setup of `GPG_TTY` failed and the variable 
wasn't explicitly set by the user either. Let me try to express that better in 
a followup amend :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#discussion_r444301782
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to