@mlschroe commented on this pull request.
>
/* Lua scripts can change our cwd and umask, save and restore */
cwd = open(".", O_RDONLY);
if (cwd != -1) {
mode_t oldmask = umask(0);
umask(oldmask);
pid_t pid = getpid();
+ /* Arrange arguments to appear as a local arg[n] table in the script */
+ char *s = rstrscat(NULL, argvp ? "arg = {...}\n" : "", script, NULL);
argvp can not be NULL so you might want to drop the test. (The rest of the code
already assumes that it is not NULL.)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1383#pullrequestreview-503662862_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
