> I was about to ask whether you're expecting a review on this (generally PR's
> with failing tests will not be looked at), but then I noticed this is a
> "draft", I didn't even know GH has such a (handy looking) feature so thanks
> for the tip
Yeah, it's nice. It's just the `[WIP]` prefix, "standardized", plus it prevents
one from accidentally merging it (which probably never happens anyway, but it
improves peace of mind) :)
> * Do split the log message improvements to a separate PR from the rpmlog
> infrastructure work
Good point. I'll split it later.
> * For the task of finding the last newline, the standard C library has
> (for once!) strrchr() so you don't need to do that manually
Oh, of course. What I wanted was the _index_ of the last non-newline char,
which is why I didn't go for `strchr()` as it returns a pointer... except that
it didn't occur to me that you can get the index with simple pointer
arithmetic... sigh. Thanks for noticing :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1429#issuecomment-732110842
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
