I did some testing in dnfdaemon and the patch is working for us. Just (as Panu
mentioned) for consistency I'd like to change CompleteTransaction signal name
to EndTransaction - the signal is emitted regardless the transaction was
successful and "Complete" in the name suggests the success.
I was also thinking whether the result of the transaction should be part of the
signal but having rpmdb cookie is perfectly fine with us to decide whether
there actually was any change.
I suppose the plugin will be released as a separate sub-package so that the
dnfdaemon could depend on it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-733608943
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
