The handling of "parse" type builtins is kind of weird. I would prefer to have
the parsing outside of doExpandThisMacro() so that I can set args to [ "foo",
"bar" ] and expand the %define macro to do a `%define foo bar`
We only have 5 builtin macros that are "parse" type: define, global, undefine,
dnl, dump
So this doesn't matter much and splitting the parsing from the processing is
probably not worth the hassle. (Btw, the parsing of the undefine and dump
macros is quite weird.)
With other words: Ok from my side. Feel free to ignore my ramblings ;-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1434#issuecomment-733977053
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
