@pmatilai commented on this pull request.


> @@ -106,7 +106,8 @@ typedef   enum rpmRC_e {
     RPMRC_NOTFOUND     = 1,    /*!< Generic not found code. */
     RPMRC_FAIL         = 2,    /*!< Generic failure code. */
     RPMRC_NOTTRUSTED   = 3,    /*!< Signature is OK, but key is not trusted. */
-    RPMRC_NOKEY                = 4     /*!< Public key is unavailable. */
+    RPMRC_NOKEY                = 4,    /*!< Public key is unavailable. */
+    RPMRC_PLUGIN_CONTENTS = 5     /*!< fsm_file_pre plugin is handling content 
*/

NAK for adding what effectively is an internal corner case to the highly 
visible RPMRC enum.
RPMRC was originally supposed to be a package open result, but is (mis)used for 
all sorts of bad and worse purposes throughout rpm, more likely we should move 
the plugins to use a separate error code system.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1470#pullrequestreview-561734509
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to