@DemiMarie commented on this pull request.
> @@ -169,8 +169,8 @@ rpmRC rpmpkgRead(struct rpmvs_s *vs, FD_t fd,
goto exit;
}
- /* Read the signature header. Might not be in a contiguous region. */
- if (hdrblobRead(fd, 1, 0, RPMTAG_HEADERSIGNATURES, sigblob, &msg))
+ /* Read the signature header. Must be in a contiguous region. */
+ if (hdrblobRead(fd, 1, 1, RPMTAG_HEADERSIGNATURES, sigblob, &msg))
Closing this. It turns out that the relevant code is at least somewhat robust
(it passed fuzzing with libfuzzer for a couple of hours with no bugs found). I
still recommend removing it from the attack surface, but for now there are
bigger wins to be had elsewhere.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1471#discussion_r554923997_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
