Oh, indeed. Thanks for spotting this!
Also kudos for checking for the `fprintf()` return value - although it still
returns a positive value in case of an `ENOSPC`, there could be other errors,
so why not check for them right away.
That said, I realized I should've moved the `free(val)` statement above the new
conditional in my original patch. So while at it, could you please incorporate
that, too? Either storing the return value of `fprintf()` in a variable and
then doing the `free(val)`, or just putting another `free(val)` call just
before the `exit(EXIT_FAILURE)` statement should be fine.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1566#issuecomment-799603408
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
