PR #1606 (commit 75275a87cff04da65d3557f2c40ea2b526528c4c) changed macro file 
loading in a subtle way. Prior to that, the both macros in the following would 
be loaded. Now, anything coming after the comment gets silently discarded:

```
%xmacro1 foo
# %{
%xmacro2 bar
```

> [pmatilai🎩︎lumikko rpm]$ ./rpm --showrc|grep xmac
-13: xmacro1    foo
[pmatilai🎩︎lumikko rpm]$

There are two ways to see this: either the contents of comment lines should be 
completely ignored, or this should emit an error about an unterminated macro. 
In *spec*, macros are expanded in comments too so the latter would be more 
consistent with that, but in macro files we're not expanding anything ever 
which suggests the former should be the right behavior. Thoughts? @mlschroe , 
others...



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1659
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to