@pmatilai commented on this pull request.
> @@ -503,6 +500,9 @@ static int pgpPrtSubType(const uint8_t *h, size_t hlen,
> pgpSigType sigtype,
case PGPSUBTYPE_REVOKE_REASON:
case PGPSUBTYPE_FEATURES:
case PGPSUBTYPE_EMBEDDED_SIG:
+ pgpPrtHex("", p+1, plen-1);
+ break;
+ case PGPSUBTYPE_NOTATION:
I fail to see how notations are any different from all the other stuff in the
above that we don't handle. I mean, if "recognizing" is a matter of being in a
switch-case then PGPSUBTYPE_NOTATION is just as "recognized" as, say,
PGPSUBTYPE_REVOKE_KEY. And if not, then most of these should be in the "not
recognized" category, which is basically what my "implemented" flag did.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1813#pullrequestreview-790700598_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
