OK, finally looking at the proper diff between my and your version:

`pkgGoalString` is missing entries for `PKG_PREUNTRANS` and `PKG_POSTUNTRANS`

The other differences are due to different naming, you not adding `RPMSENSE_` 
flags and my patch being incomplete.

Missing `RPMSENSE_` flags means there is currently no way to declare 
`Requires(preuntrans)` and `Requires(postuntrans)`. May be that is not 
necessary and we can use `Requires(pretrans)`/`Requires(posttrans)`.
Reusing `RPMSENSE_PRETRANS` and `RPMSENSE_POSTTRANS` in that way raises the 
question whether they should be part of the `_ERASE_ONLY_MASK`, though. This is 
kinda weird.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2177#issuecomment-1254740111
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2177/c1254740...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to