@pmatilai commented on this pull request.
> + * a copy of the version number.
+ */
+static char *getLibtoolVer(const char *filename)
+{
+ const char *so;
+ char dest[PATH_MAX];
+ int destsize = 0;
+ int found_digit = 0, found_dot = 0;
+
+ destsize = readlink(filename, dest, PATH_MAX);
+ if (destsize > 0) {
+ dest[destsize] = 0;
+ filename = dest;
+ }
+ // Start from the end of the string. Verify that it ends with
+ // numbers and dots, preceded by ".so.".
On a purely stylistical nit, `//` comments do not belong in rpm coding style.
Always use `/* ... */` and for multiline comments,
```
/*
* ...
* ...
*/
```
/me realizes this isn't even explained in contributing.md, sigh...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2372#pullrequestreview-1284678640
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2372/review/1284678...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
