@dmnks commented on this pull request.
> @@ -1174,6 +1177,89 @@ static void doShescape(MacroBuf mb, rpmMacroEntry me,
> ARGV_t argv, size_t *parse
mbAppend(mb, '\'');
}
+static unsigned long getmem_total(void)
+{
+ unsigned long mem = 0;
+ long int pagesize = sysconf(_SC_PAGESIZE);
+ long int pages = sysconf(_SC_PHYS_PAGES);
+
+ if (pagesize < 0)
+ pagesize = 4096;
+ if (pages > 0)
+ mem = pages * pagesize;
+
+ return mem;
+}
+
+static unsigned long getmem_proc(int thread)
Wouldn't it be better to add a separate `getmem_thread()` function for the
thread case? There doesn't seem to be much they have in common, apart from the
`getmem_total()` call.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2418#pullrequestreview-1353037381
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2418/review/1353037...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
