The issues with this one start with the topic. Reproducible builds are
reproducible whether manually or automatically, we don't need this patch for
that. None of this makes any sense without reading up a whole lot of additional
context as to how some initially unmentioned buildsystem processes things.
I can understand the basic idea of throwing away builds that didn't actually
change, but I get lost in the details. For example:
> If a build e.g. embeds SOURCE_DATE_EPOCH in the output, then the output
> changes every time such a rebuild happens, which can be very often.
It only changes if you change SOURCE_DATE_EPOCH, and if you took the
SOURCE_DATE_EPOCH from the changelog then it only changes if you change the
changelog, and at that point its no longer the same. By my logic anyhow. It's
really hard to constructively comment on what you don't understand. A test-case
outside any complicated build-system machineries would perhaps help understand
this on a more concrete level. Also, this lumps a whole lot of changes into one
which is further bad for undestanding.
Split this up into per-change commits, adding docs and test-cases for each.
That would be required for acceptance anyhow, and should help seeing the
individual bits for what they are without needing to know how some buildsystem
somewhere processes stuff. Like already said, for example the bit about
erroring out on missing changelog is something that makes perfect sense on its
own. And OTOH I see there's an added check for SOURCE_DATE_EPOCH in the past,
which is also quite unrelated to this all (AFAICS), and which I disagree with:
ability to set the time into future is useful for testing purposes.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2880#issuecomment-1921493020
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2880/c1921493...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
