Taking weak dependencies into account during ordering has caused a noticeable wave of dependency loop caused install failure bug reports at least in Fedora. This is counter-productive: weak dependencies are commonly used to introduce more exotic / heavier dependencies to packages without causing impossible loops, but now we're doing that to ourselves.
Commit d6353c96fed98a8d30d9ebadf4d6a19a5149edee demoted scriptlet dependencies to regular ones, but this had precisely zero effect because there were no such dependencies in the wild because due to a bug that made it impossible to create such dependencies manually. That bug is now fixed, but in addition, demote non-scriptlet dependencies to meta for ordering purposes (as in, just ignore them). This helps concretely helps bringing down the number (and density) of install ordering dependency loops in the wild. It's worth mentioning that sysusers dependencies are flagged as scriptlet dependencies, so it's important that these don't get ignored even if %_use_weak_usergroup_deps is enabled. Adjust ordering tests accordingly, in particular turn the first weak dependency test into a mixed set that demonstrates the effect of this change. Fixes: #1346 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3004 -- Commit Summary -- * Ignore non-scriptlet weak dependencies in ordering -- File Changes -- M lib/order.c (18) M tests/rpmorder.at (18) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/3004.patch https://github.com/rpm-software-management/rpm/pull/3004.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3004 You are receiving this because you are subscribed to this thread. Message ID: <rpm-software-management/rpm/pull/3...@github.com>
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
