Sorry but I agree with @nwalfield , this is just strange churn for churn's 
sake. Like advertising use of goto but then still using return for the cases 
that *could* use a central clean-up point. Even the changes that I could use 
because I suggested them are mixed with unrelated other changes, moving stuff 
around needlessly etc. Even the change to "rpm coding style" is anything but, 
the code is almost 100% that already.

A 118 line simple program that only ever executes as a part of the test-suite 
does not need much in the way of cleanup, really.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-2095296257
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/3072/c2095296...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to