@pmatilai commented on this pull request.
> @@ -229,6 +229,28 @@ char * rpmPubkeyBase64(rpmPubkey key)
return enc;
}
+rpmRC rpmPubkeyMerge(rpmPubkey oldkey, rpmPubkey newkey, rpmPubkey *mergedkeyp)
+{
+ rpmPubkey mergedkey = NULL;
+ uint8_t *mergedpkt = NULL;
+ size_t mergedpktlen = 0;
+ rpmRC rc;
+
+ pthread_rwlock_rdlock(&oldkey->lock);
+ pthread_rwlock_rdlock(&newkey->lock);
I don't think we have a defined locking order for anything in rpm. The locks on
they keys are probably a bit hokey to begin with because librpm and threads is
playing with fire anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3083#discussion_r1611406952
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3083/review/2073509...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
