@Jakuje commented on this pull request.
> @@ -606,19 +611,31 @@ Supplements: (%{name} = %{version}-%{release} and
> langpacks-%{1})\
%_db_backend @DB_BACKEND@
#==============================================================================
-# ---- GPG/PGP/PGP5 signature macros.
-# Macro(s) to hold the arguments passed to GPG/PGP for package
+# ---- OpenPGP signature macros.
+# Macro(s) to hold the arguments passed to the implementating cmd package
not native english, but the `implementating` sounds awkward to me here. Should
this be `implementation` or something else?
```suggestion
# Macro(s) to hold the arguments passed to the implementation of cmd
package
```
> +# XXX This gpg2 import is unrelated to the actual signing, but unless gpg2
+# has run once, sq import fails due to some gpg-agent communication error.
does it actually fail and exit with non-zero exit code? From my experiments,
the agent failures were there, but the signatures went through just ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3282#pullrequestreview-2289365288
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3282/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint
