Should've been in commit 0cd74ade37d16d282d13e781deb68a219b2c04b9 already, 
didn't even realize we have such a hardcoded default in code too until 
accidentally stumbled on it a few days ago.

This only affects anything if rpm's own normal macro configuration 
isn't available at all, so just an obscure corner case.

A funny little gotcha is that inserting RPMTAG_FILEDIGESTALGO tag depended on 
defaultalgo being MD5, so the obvious one-liner change caused a whopping 104 
test failures. The tag needs to be added on any non-MD5 algorithm, change it to 
test for that explicitly.

So I guess it needs some tests afterall...
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3326

-- Commit Summary --

  * Bump the lowest level file digest default to SHA256 too

-- File Changes --

    M build/files.c (12)
    M tests/rpmbuild.at (57)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3326.patch
https://github.com/rpm-software-management/rpm/pull/3326.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3326
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to