@dmnks commented on this pull request.
LGTM (just added a forgotten removal of `target_compile_options()` in
`tools/CMakeLists.txt` on top as a fixup), but one question inline.
> (void) Fclose(fd);
}
- if (rc != pktlen) {
+ if (nb != pktlen) {
This is probably silly but I do wonder: Is there a remote chance that `pktlen`
would be 0 here? If so, we would no longer error out in case the file couldn't
be opened.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3989#pullrequestreview-3314947304
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/3989/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
