https://bugzilla.rpmfusion.org/show_bug.cgi?id=4441
--- Comment #20 from Andrew Bauer <zonexpertconsult...@outlook.com> ---
Results of fedora-review. Comments will follow in the next post:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
===== MUST items =====
C/C++:
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 78 files have unknown license. Detailed
output of licensecheck in /home/abauer/discord/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://dl.discordapp.net/apps/linux/0.0.3/discord-0.0.3.tar.gz
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: discord-0.0.3-1.fc28.x86_64.rpm
discord-0.0.3-1.fc28.src.rpm
discord.x86_64: E: explicit-lib-dependency libappindicator(x86-64)
discord.x86_64: E: explicit-lib-dependency libcxx(x86-64)
discord.x86_64: E: explicit-lib-dependency libnotify(x86-64)
discord.x86_64: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
discord.x86_64: W: invalid-license Proprietary
discord.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/discord/Discord
['$ORIGIN', '$ORIGIN/lib/']
discord.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/discord/Discord
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_erlpack.zip readelf:
/tmp/rpmlint.discord-0.0.3-1.fc28.x86_64.rpm.ee4_qwnu/usr/lib64/discord/resources/bootstrap/discord_erlpack.zip:
Error: Not an ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_game_utils.zip readelf:
/tmp/rpmlint.discord-0.0.3-1.fc28.x86_64.rpm.ee4_qwnu/usr/lib64/discord/resources/bootstrap/discord_game_utils.zip:
Error: Not an ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_utils.zip readelf:
/tmp/rpmlint.discord-0.0.3-1.fc28.x86_64.rpm.ee4_qwnu/usr/lib64/discord/resources/bootstrap/discord_utils.zip:
Error: Not an ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_voice.zip readelf:
/tmp/rpmlint.discord-0.0.3-1.fc28.x86_64.rpm.ee4_qwnu/usr/lib64/discord/resources/bootstrap/discord_voice.zip:
Error: Not an ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: no-documentation
discord.x86_64: W: no-manual-page-for-binary Discord
discord.x86_64: W: desktopfile-without-binary
/usr/share/applications/discord.desktop /usr/bin/Discord
discord.src: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
discord.src: W: invalid-license Proprietary
discord.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 13)
2 packages and 0 specfiles checked; 5 errors, 12 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
discord.x86_64: E: explicit-lib-dependency libappindicator(x86-64)
discord.x86_64: E: explicit-lib-dependency libcxx(x86-64)
discord.x86_64: E: explicit-lib-dependency libnotify(x86-64)
discord.x86_64: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
discord.x86_64: W: invalid-license Proprietary
discord.x86_64: W: invalid-url URL: https://discordapp.com/ <urlopen error
[Errno -2] Name or service not known>
discord.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/discord/Discord
['$ORIGIN', '$ORIGIN/lib/']
discord.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/discord/Discord
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_erlpack.zip readelf:
/usr/lib64/discord/resources/bootstrap/discord_erlpack.zip: Error: Not an ELF
file - it has the wrong magic bytes at the start
discord.x86_64: W: ldd-failed
/usr/lib64/discord/resources/bootstrap/discord_erlpack.zip
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_game_utils.zip readelf:
/usr/lib64/discord/resources/bootstrap/discord_game_utils.zip: Error: Not an
ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: ldd-failed
/usr/lib64/discord/resources/bootstrap/discord_game_utils.zip
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_utils.zip readelf:
/usr/lib64/discord/resources/bootstrap/discord_utils.zip: Error: Not an ELF
file - it has the wrong magic bytes at the start
discord.x86_64: W: ldd-failed
/usr/lib64/discord/resources/bootstrap/discord_utils.zip
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_voice.zip readelf:
/usr/lib64/discord/resources/bootstrap/discord_voice.zip: Error: Not an ELF
file - it has the wrong magic bytes at the start
discord.x86_64: W: ldd-failed
/usr/lib64/discord/resources/bootstrap/discord_voice.zip
discord.x86_64: W: no-documentation
discord.x86_64: W: no-manual-page-for-binary Discord
1 packages and 0 specfiles checked; 5 errors, 13 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
