https://bugzilla.rpmfusion.org/show_bug.cgi?id=4852
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #2 from Robert-André Mauchin <zebo...@gmail.com> ---
- Not needed %defattr(-,root,root,-)
- The unit file should probably not be using %config(noreplace)
- I doubt -ugly and -bad are necessary, if we look at the Arch package, they
are marked as "optional", thus I don't think this package should be in
RPMFusion, but Fedora proper, without these as hard dependencies.
I don't know if packages from Fedora can add Recommends: to RPMFusion
packages, any one knows if it's okay?
- This package could probably benefit from the new Forge automation:
https://fedoraproject.org/wiki/Forge-hosted_projects_packaging_automation
Use:
%global forgeurl https://github.com/hzeller/gmrender-resurrect
%global commit 4f221e6b85abf85957b547436e982d7a501a1718
%forgemeta
Name: gmediarender
Version: 0
Release: 0.8%{?dist}
Summary: Resource efficient UPnP/DLNA renderer
License: GPLv2+
URL: %{forgeurl}
Source: %{forgesource}
(dist will be computed automatically)
And in %prep:
%prep
%forgeautosetup
autoreconf -vfi
The %changelog needs adjustement:
* Sat Apr 07 2018 Zamir SUN <szts...@gmail.com> - 0-0.8.20180407git4f221e6
- Fix versioning
- Update to upstream head 4f221e6
Please note the snapshot date must be the date the archive is downloaded (or
uploaded to fedora/rpmfusion servers) and not the date of the commit, contrary
to what it was before believed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
