https://bugzilla.rpmfusion.org/show_bug.cgi?id=6089

leigh scott <leigh123li...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leigh123li...@gmail.com

--- Comment #1 from leigh scott <leigh123li...@gmail.com> ---
1: Please use the meson macros


Change:

%__meson  -D auto_features=disabled -D examples=disabled \
          -D bluez5=enabled -D bluez5-codec-aptx=enabled \
          %{_vpath_srcdir} %{_vpath_builddir}
%__meson compile -C %{_vpath_builddir} spa-codec-bluez5-aptx


To:

%build
%meson --auto-features=disabled -D examples=disabled \
       -D bluez5=enabled -D bluez5-codec-aptx=enabled
%meson_build spa-codec-bluez5-aptx


2: There is no need to have gcc listed

Change:

BuildRequires:  gcc
BuildRequires:  g++

To:

BuildRequires:  gcc-c++


3: Remove

BuildRequires:  pkgconfig


4: Remove

%global debug_package %{nil}

All arched package MUST provide debug info

pipewire-codec-aptx.x86_64: W: unstripped-binary-or-object
/usr/lib64/spa-0.2/bluez5/libspa-codec-bluez5-aptx.so
This executable should be stripped from debugging symbols, in order to take
less space and be loaded faster. This is usually done automatically at
buildtime by rpm.

5: You could use install instead of cp


install -pm 0755
%{_vpath_builddir}/spa/plugins/bluez5/libspa-codec-bluez5-aptx.so \
   %{buildroot}%{_libdir}/spa-%{spaversion}/bluez5/


6: Why is this needed?

# where/how to apply multilib hacks
%global multilib_archs x86_64 %{ix86} ppc64 ppc s390x s390 sparc64 sparcv9
ppc64le

7: Include the MIT license

%files
%license COPYING
%{_libdir}/spa-%{spaversion}/bluez5/libspa-codec-bluez5-aptx.so

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org

Reply via email to