https://bugzilla.rpmfusion.org/show_bug.cgi?id=6213
Sérgio Basto <ser...@serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Sérgio Basto <ser...@serjux.com> ---
Note: No gcc, gcc-c++ or clang found in BuildRequires , please add it
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
Note: No gcc, gcc-c++ or clang found in BuildRequires
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License, Version
2", "GNU Lesser General Public License, Version 2.1", "GNU Lesser
General Public License, Version 3", "*No copyright* GNU General Public
License v2.0 or later", "*No copyright* GNU General Public License",
"*No copyright* GNU Lesser General Public License v2.1 or later", "GNU
Lesser General Public License v2.1 or later", "MIT License", "BSD (3
clause)", "GNU General Public License v3.0 or later", "*No copyright*
[generated file]", "GNU General Public License v2.0 or later", "BSD (3
clause) GNU Lesser General Public License v2.1 or later", "ISC
License", "BSD (2 clause) GNU Lesser General Public License v2.1 or
later", "GNU Library General Public License v2 or later", "GNU General
Public License GNU Lesser General Public License v2.1 or later", "BSD
(2 clause)", "MIT License GNU Lesser General Public License v2.1 or
later", "zlib/libpng license", "Boost Software License 1.0 GNU Lesser
General Public License v2.1 or later", "*No copyright* Public domain",
"*No copyright* MIT License", "*No copyright* Public domain GNU
General Public License". 3313 files have unknown license. Detailed
output of licensecheck in /home/sergio/github/rpmfusion_check/review-
compat-ffmpeg4/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 296960 bytes in 20 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: compat-ffmpeg4-4.3.3-1.fc36.x86_64.rpm
compat-ffmpeg4-devel-4.3.3-1.fc36.x86_64.rpm
compat-ffmpeg4-debuginfo-4.3.3-1.fc36.x86_64.rpm
compat-ffmpeg4-debugsource-4.3.3-1.fc36.x86_64.rpm
compat-ffmpeg4-4.3.3-1.fc36.src.rpm
compat-ffmpeg4.x86_64: W: spelling-error %description -l en_US FFmpeg -> MPEG
compat-ffmpeg4.x86_64: W: spelling-error %description -l en_US asf -> as, sf,
ass
compat-ffmpeg4.x86_64: W: spelling-error %description -l en_US avi -> av, vi,
avid
compat-ffmpeg4.x86_64: W: spelling-error %description -l en_US mjpeg -> JPEG
compat-ffmpeg4.x86_64: W: crypto-policy-non-compliance-gnutls-1
/usr/lib64/libavformat.so.58.45.100 gnutls_priority_set_direct
compat-ffmpeg4-devel.x86_64: W: spelling-error %description -l en_US FFmpeg ->
MPEG
compat-ffmpeg4-devel.x86_64: W: spelling-error %description -l en_US asf -> as,
sf, ass
compat-ffmpeg4-devel.x86_64: W: spelling-error %description -l en_US avi -> av,
vi, avid
compat-ffmpeg4-devel.x86_64: W: spelling-error %description -l en_US mjpeg ->
JPEG
compat-ffmpeg4-devel.x86_64: W: only-non-binary-in-usr-lib
compat-ffmpeg4.src: W: spelling-error %description -l en_US FFmpeg -> MPEG
compat-ffmpeg4.src: W: spelling-error %description -l en_US asf -> as, sf, ass
compat-ffmpeg4.src: W: spelling-error %description -l en_US avi -> av, vi, avid
compat-ffmpeg4.src: W: spelling-error %description -l en_US mjpeg -> JPEG
5 packages and 0 specfiles checked; 0 errors, 14 warnings.
Rpmlint (debuginfo)
-------------------
Checking: compat-ffmpeg4-debuginfo-4.3.3-1.fc36.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Source checksums
----------------
http://ffmpeg.org//releases/ffmpeg-4.3.3.tar.xz :
CHECKSUM(SHA256) this package :
9f0a68fbd74feb4e50dc220bddd59d84626774a53687fb737806ae00e5c6e9e6
CHECKSUM(SHA256) upstream package :
9f0a68fbd74feb4e50dc220bddd59d84626774a53687fb737806ae00e5c6e9e6
Requires
--------
compat-ffmpeg4 (rpmlib, GLIBC filtered):
glibc
libGL.so.1()(64bit)
libOpenCL.so.1()(64bit)
libOpenCL.so.1(OPENCL_1.0)(64bit)
libOpenCL.so.1(OPENCL_1.2)(64bit)
libX11.so.6()(64bit)
libaom.so.3()(64bit)
libasound.so.2()(64bit)
libasound.so.2(ALSA_0.9)(64bit)
libasound.so.2(ALSA_0.9.0rc4)(64bit)
libass.so.9()(64bit)
libavcodec.so.58()(64bit)
libavcodec.so.58(LIBAVCODEC_58)(64bit)
libavfilter.so.7()(64bit)
libavfilter.so.7(LIBAVFILTER_7)(64bit)
libavformat.so.58()(64bit)
libavformat.so.58(LIBAVFORMAT_58)(64bit)
libavresample.so.4()(64bit)
libavresample.so.4(LIBAVRESAMPLE_4)(64bit)
libavutil.so.56()(64bit)
libavutil.so.56(LIBAVUTIL_56)(64bit)
libbluray.so.2()(64bit)
libbz2.so.1()(64bit)
libc.so.6()(64bit)
libcairo.so.2()(64bit)
libcdio_cdda.so.2()(64bit)
libcdio_cdda.so.2(CDIO_CDDA_2)(64bit)
libcdio_paranoia.so.2()(64bit)
libcdio_paranoia.so.2(CDIO_PARANOIA_2)(64bit)
libdav1d.so.5()(64bit)
libdrm.so.2()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libfribidi.so.0()(64bit)
libgcrypt.so.20()(64bit)
libgcrypt.so.20(GCRYPT_1.6)(64bit)
libglib-2.0.so.0()(64bit)
libgnutls.so.30()(64bit)
libgnutls.so.30(GNUTLS_3_4)(64bit)
libgobject-2.0.so.0()(64bit)
libgsm.so.1()(64bit)
libjack.so.0()(64bit)
liblzma.so.5()(64bit)
liblzma.so.5(XZ_5.0)(64bit)
libm.so.6()(64bit)
libmfx.so.1()(64bit)
libmfx.so.1(LIBMFX_1.0)(64bit)
libmfx.so.1(LIBMFX_1.14)(64bit)
libmfx.so.1(LIBMFX_1.8)(64bit)
libmodplug.so.1()(64bit)
libmp3lame.so.0()(64bit)
libmysofa.so.1()(64bit)
libopenal.so.1()(64bit)
libopencore-amrnb.so.0()(64bit)
libopencore-amrwb.so.0()(64bit)
libopenjp2.so.7()(64bit)
libopenmpt.so.0()(64bit)
libopus.so.0()(64bit)
libpostproc.so.55()(64bit)
libpostproc.so.55(LIBPOSTPROC_55)(64bit)
libpulse.so.0()(64bit)
libpulse.so.0(PULSE_0)(64bit)
librsvg-2.so.2()(64bit)
libsoxr.so.0()(64bit)
libspeex.so.1()(64bit)
libssh.so.4()(64bit)
libssh.so.4(LIBSSH_4_5_0)(64bit)
libswresample.so.3()(64bit)
libswresample.so.3(LIBSWRESAMPLE_3)(64bit)
libswscale.so.5()(64bit)
libswscale.so.5(LIBSWSCALE_5)(64bit)
libtheoradec.so.1()(64bit)
libtheoradec.so.1(libtheoradec_1.0)(64bit)
libtheoraenc.so.1()(64bit)
libtheoraenc.so.1(libtheoraenc_1.0)(64bit)
libv4l2.so.0()(64bit)
libva-drm.so.2()(64bit)
libva.so.2()(64bit)
libva.so.2(VA_API_0.33.0)(64bit)
libvdpau.so.1()(64bit)
libvidstab.so.1.2()(64bit)
libvo-amrwbenc.so.0()(64bit)
libvorbis.so.0()(64bit)
libvorbisenc.so.2()(64bit)
libvpx.so.7()(64bit)
libx264.so.163()(64bit)
libx265.so.199()(64bit)
libxcb-shape.so.0()(64bit)
libxcb-shm.so.0()(64bit)
libxcb-xfixes.so.0()(64bit)
libxcb.so.1()(64bit)
libxml2.so.2()(64bit)
libxml2.so.2(LIBXML2_2.4.30)(64bit)
libxml2.so.2(LIBXML2_2.6.0)(64bit)
libxml2.so.2(LIBXML2_2.7.3)(64bit)
libxvidcore.so.4()(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
libz.so.1(ZLIB_1.2.0.2)(64bit)
libzimg.so.2()(64bit)
libzvbi.so.0()(64bit)
rtld(GNU_HASH)
compat-ffmpeg4-devel (rpmlib, GLIBC filtered):
compat-ffmpeg4(x86-64)
libavcodec.so.58()(64bit)
libavdevice.so.58()(64bit)
libavfilter.so.7()(64bit)
libavformat.so.58()(64bit)
libavresample.so.4()(64bit)
libavutil.so.56()(64bit)
libpostproc.so.55()(64bit)
libswresample.so.3()(64bit)
libswscale.so.5()(64bit)
pkgconfig
compat-ffmpeg4-debuginfo (rpmlib, GLIBC filtered):
compat-ffmpeg4-debugsource (rpmlib, GLIBC filtered):
Provides
--------
compat-ffmpeg4:
compat-ffmpeg4
compat-ffmpeg4(x86-64)
libavcodec.so.58()(64bit)
libavcodec.so.58(LIBAVCODEC_58)(64bit)
libavdevice.so.58()(64bit)
libavdevice.so.58(LIBAVDEVICE_58)(64bit)
libavfilter.so.7()(64bit)
libavfilter.so.7(LIBAVFILTER_7)(64bit)
libavformat.so.58()(64bit)
libavformat.so.58(LIBAVFORMAT_58)(64bit)
libavresample.so.4()(64bit)
libavresample.so.4(LIBAVRESAMPLE_4)(64bit)
libavutil.so.56()(64bit)
libavutil.so.56(LIBAVUTIL_56)(64bit)
libpostproc.so.55()(64bit)
libpostproc.so.55(LIBPOSTPROC_55)(64bit)
libswresample.so.3()(64bit)
libswresample.so.3(LIBSWRESAMPLE_3)(64bit)
libswscale.so.5()(64bit)
libswscale.so.5(LIBSWSCALE_5)(64bit)
compat-ffmpeg4-devel:
compat-ffmpeg4-devel
compat-ffmpeg4-devel(x86-64)
compat-ffmpeg4-debuginfo:
compat-ffmpeg4-debuginfo
compat-ffmpeg4-debuginfo(x86-64)
debuginfo(build-id)
libavcodec.so.58.91.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libavdevice.so.58.10.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libavfilter.so.7.85.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libavformat.so.58.45.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libavresample.so.4.0.0-4.3.3-1.fc36.x86_64.debug()(64bit)
libavutil.so.56.51.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libpostproc.so.55.7.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libswresample.so.3.7.100-4.3.3-1.fc36.x86_64.debug()(64bit)
libswscale.so.5.7.100-4.3.3-1.fc36.x86_64.debug()(64bit)
compat-ffmpeg4-debugsource:
compat-ffmpeg4-debugsource
compat-ffmpeg4-debugsource(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review --url
https://bugzilla.rpmfusion.org/show_bug.cgi?id=6213 -m
fedora-rawhide-x86_64-rpmfusion_nonfree
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: PHP, Ocaml, Haskell, R, Java, SugarActivity, Python, Ruby,
fonts, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Very clean
Package approved !
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- rpmfusion-developers@lists.rpmfusion.org
To unsubscribe send an email to rpmfusion-developers-le...@lists.rpmfusion.org
