Hi Mamoru,
thank you again for your support.
With your guidance, after changing the Init_DDraw() call, now gens compiles
for f42 and rawhide.
I tested the f42 version and it segfaults at start-up in Init_DDraw() :-(
Maybe the time has come to retire this relic of the past.
BR,
Andrea
On Wed, Aug 6, 2025 at 2:00 PM Mamoru TASAKA via rpmfusion-developers <
[email protected]> wrote:
> Andrea Musuruane wrote on 2025/08/06 18:55:
> > Hi Mamoru,
> > thank you very much for looking into this.
> >
> > I made a patch and I updated the spec file but it seems I cannot run
> "rfpkg
> > mockbuild --root fedora-rawhide-i386-rpmfusion_nonfree". Do you know how
> > can I test the build locally before pushing the changes to RPM Fusion?
> >
> > BR,
> >
> > Andrea
>
> Since all BuildRequires are available within Fedora package, for now
> you can use mormal "mock" command using fedora-rawhide-i386 target.
>
> Regards,
> Mamoru
>
> >
> >
> > On Tue, Aug 5, 2025 at 11:55 AM Mamoru TASAKA via rpmfusion-developers <
> > [email protected]> wrote:
> >
> >> Andrea Musuruane via rpmfusion-developers wrote on 2025/08/05 17:16:
> >>> Hi,
> >>>
> >>> On Fri, Aug 1, 2025 at 2:16 PM Sérgio Basto via rpmfusion-developers <
> >>> [email protected]> wrote:
> >>>
> >>>> Pakages:
> >>>> gens
> >>>
> >>>
> >>> I need help with this. If someone has some spare time, it will be
> >>> appreciated :-)
> >>>
> >>> Thanks,
> >>>
> >>> Andrea
> >>>
> >>
> >> Well, actually I understand what build log says (compiler complains),
> >> and have idea how to make compiler happy, however for now I cannot judge
> >> if my idea is actually "correct"...
> >>
> >> So compiler complains:
> >>
> >> emulator/ui_proxy.c: In function ‘Change_VSync’:
> >> emulator/ui_proxy.c:893:20: error: too many arguments to function
> >> ‘Init_DDraw’; expected 0, have 3
> >> 893 | return Init_DDraw (640, 480,
> >> | ^~~~~~~~~~ ~~~
> >> In file included from emulator/ui_proxy.c:12:
> >> ./sdllayer/g_sdldraw.h:30:5: note: declared here
> >> 30 | int Init_DDraw();
> >>
> >> So at a first glance, it seems that the prototypes on
> >> sdllayer/g_sdldraw.h should be fixed like:
> >> int Init_DDraw(int, int, int);
> >>
> >> However the trouble is that this "int Init_DDraw()" is actually
> >> defined in src/gens/sdllayer/g_sdldraw.c:228 :
> >> and looking into the actual definition of "int Init_DDraw()", so
> >> width and height information are taken from global variables.
> >>
> >> So even if emulator/ui_proxy.c:893 calls Init_DDraw as:
> >>
> >> 893 return Init_DDraw (640, 480,
> >> 894 SDL_HWSURFACE | SDL_DOUBLEBUF |
> >> 895 SDL_FULLSCREEN);
> >>
> >> actually these 3 arguments are currently completely ignored...
> >> I don't know if this is really expected.
> >>
> >> So currently I have no idea what is the "expected" (or "correct") fix...
> >>
> >> For now, if it is okay to just keep current behavior (by gcc14),
> >> changing the above Init_DDraw() call on emulator/ui_proxy.c:893 to
> >>
> >> return Init_DDraw();
> >>
> >> should be okay.
> >>
> >> Regards,
> >> Mamoru
> >> _______________________________________________
> >> rpmfusion-developers mailing list --
> >> [email protected]
> >> To unsubscribe send an email to
> >> [email protected]
> >>
> >
> _______________________________________________
> rpmfusion-developers mailing list --
> [email protected]
> To unsubscribe send an email to
> [email protected]
>
_______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
