https://bugzilla.rpmfusion.org/show_bug.cgi?id=7418
--- Comment #3 from Greg Lamberson <[email protected]> ---
Thanks Ivan. The updated spec looks good, and those changes address the items I
raised.
For the sed removal, I had suggested converting it to a named patch, but you
found the line doesn't exist in the source anymore, so dropping it entirely
makes sense. That's cleaner than either option.
The cmake-style provides for Qt dependencies is a good practice.
I'm satisfied with the packaging side. As I noted, the API credential and
impersonation aspects are policy questions for the formal reviewer to weigh in
on.
Greg Lamberson
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
