Modify configure.ac to check for a C99 compiler, and other
fixes/cleanups.
Changes in v2:
* add a paragraph to the commit message in 2/10 to explain why it's
OK to remove the MySQL header and function checks
* restore the call to AC_PROG_CC in 4/10
* add a paragraph to the commit message in 4/10 to explain why the
call to AC_PROG_CC was left in
>From the reply to 4/10:
On 2015-07-07 15:54, David Mandelberg wrote:
> On 2015-07-07 00:49, Richard Hansen wrote:
>> Use the AC_PROG_CC_C99 macro in configure.ac to ensure that the
>> compiler can handle C99 features by putting it in C99 mode (e.g.,
>> by using the -std=gnu99 argument to gcc). If the compiler doesn't
>> support C99, exit with an error.
>>
>> (We currently use some C99 features like inline functions,
>> intermingled declarations and code, long long int, compound
>> literals, variable-length arrays, // comments, snprintf(), variadic
>> macros, etc. Eventually we will want to use the restrict keyword.)
>> ---
>> configure.ac | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 80adbb6..0b83849 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -52,7 +52,9 @@ AC_SUBST([MIN_PYTHON_VERSION])
>> AM_MAINTAINER_MODE
>> : ${CFLAGS=""}
>> # Checks for programs.
>> -AC_PROG_CC
>
> Don't you still need to call AC_PROG_CC?
Technically no; the AC_PROG_CC_C99 macro calls
AC_REQUIRE([AC_PROG_CC]) so any other call to AC_PROG_CC is
unnecessary. However, the Autoconf documentation does not say that
AC_PROG_CC_C99 calls AC_PROG_CC, so I added it back (it's safe to
expand AC_PROG_CC multiple times).
Richard Hansen (10):
configure.ac: quote underquoted strings
configure.ac: remove unnecessary checks
configure.ac: require autoconf 2.60
configure.ac: require C99 compiler
configure.ac: avoid obsolete -a argument to test
configure.ac: use AC_MSG_ERROR instead of echo and exit
configure.ac, autogen.sh: wrap long lines where possible
autogen.sh: turn on warnings
autogen.sh: avoid inconsistent 'set -e'
autogen.sh: avoid a fork
autogen.sh | 8 ++---
configure.ac | 111 +++++++++++++++++++++++++++++++----------------------------
2 files changed, 63 insertions(+), 56 deletions(-)
--
2.4.5
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
rpstir-devel mailing list
rpstir-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rpstir-devel
