A collection of fixes for minor issues I noticed while working on
other stuff.
Richard Hansen (20):
delete unused file
whitespace fixes
keep lines under 80 characters long
reflow comments
delete RCS keywords and other VCS detritus
add missing #include guard in lib/rpki/querySupport.h
add missing #includes and forward declarations
use typedefs instead of #defines for uchar, ushort, ulong
include corresponding .h files before other headers
use 0 instead of false
use 'do {...} while (0)' for macros
move function documentation to function declaration
convert comments to Doxygen-style comments
minor comment cleanups (typo fixes, wording improvements)
document checkValidity() parameters and return value
allow {Local,Unix}TimeToDBTime() stap argument to be NULL
delete unused variable
move one-time search initialization to a separate function
reduce indentation by inverting logic
remove unnecessary PROG variable
README.in | 8 +-
bin/asn1/asn_dump.c | 3 +-
bin/asn1/dump.c | 7 +-
bin/asn1/make_oidtable.c | 5 -
bin/asn1/rr.c | 25 +-
bin/asn1/util.c | 38 +-
bin/rpki-local-ta/test_cert.c | 2 +-
bin/rpki-local-ta/testrpwork.c | 4 -
bin/rpki-object/add_cms_cert.c | 7 +-
bin/rpki-object/add_cms_cert_no_check.c | 2 +-
bin/rpki-object/add_key_info.c | 5 -
bin/rpki-object/check_signature.c | 4 -
bin/rpki-object/create_object/create_cert.c | 21 +-
bin/rpki-object/create_object/create_cert.h | 4 +-
bin/rpki-object/create_object/create_crl.c | 9 +-
bin/rpki-object/create_object/create_crl.h | 4 +-
bin/rpki-object/create_object/create_manifest.c | 36 +-
bin/rpki-object/create_object/create_manifest.h | 2 +-
bin/rpki-object/create_object/create_object.c | 14 +-
bin/rpki-object/create_object/create_object.h | 8 +-
bin/rpki-object/create_object/create_roa.c | 14 +-
bin/rpki-object/create_object/create_roa.h | 2 +-
bin/rpki-object/create_object/create_utils.c | 38 +-
bin/rpki-object/create_object/obj_err.h | 4 +-
bin/rpki-object/extractPubKeyInfo.c | 2 +-
bin/rpki-object/extractSIA.c | 20 +-
bin/rpki-object/extractValidityDate.c | 12 +-
bin/rpki-object/fix_manifest.c | 5 -
bin/rpki-object/gen_key.c | 4 -
bin/rpki-object/loadkey.c | 4 -
bin/rpki-object/makeROA.c | 5 -
bin/rpki-object/make_manifest.c | 9 +-
bin/rpki-object/make_roa.c | 5 -
bin/rpki-object/put_sia.c | 26 +-
bin/rpki-object/set_cert_ski.c | 6 -
bin/rpki-object/sign_cert.c | 7 +-
bin/rpki-object/sign_cms.c | 8 +-
bin/rpki-object/update_cert.c | 5 -
bin/rpki-rsync/csapp.c | 102 +-
bin/rpki-rsync/csapp.h | 54 +-
bin/rpki-rsync/main.c | 65 +-
bin/rpki-rsync/main.h | 4 -
bin/rpki-rsync/parse.c | 115 +-
bin/rpki-rsync/parse.h | 6 +-
bin/rpki-rsync/rsync_cord.py.in | 12 +-
bin/rpki-rsync/sig_handler.c | 10 +-
bin/rpki-rsync/sig_handler.h | 4 -
bin/rpki-rsync/socket_stuff.c | 22 +-
bin/rpki-rsync/socket_stuff.h | 4 -
bin/rpki-rsync/usage.c | 9 +-
bin/rpki-rsync/usage.h | 4 -
bin/rpki-rtr/cache_state.c | 4 +-
bin/rpki-rtr/config.h | 2 +-
bin/rpki-rtr/connection.c | 17 +-
bin/rpki-rtr/connection_control.c | 7 +-
bin/rpki-rtr/db.c | 13 +-
bin/rpki-rtr/db.h | 2 +-
bin/rpki-rtr/rtr-update.c | 2 +-
bin/rpki-rtr/signals.c | 4 +-
bin/rpki-rtr/test-client.c | 2 +-
bin/rpki/chaser.c | 2 +-
bin/rpki/garbage.c | 6 +-
bin/rpki/query.c | 25 +-
bin/rpki/rcli.c | 74 +-
bin/rpki/results.py.in | 4 +-
bin/rpki/updateTA.py.in | 16 +-
doc/AUR.readme | 169 +-
doc/CHASER-OUTLINE | 3 +-
doc/ConformanceTesting_Jul_2013.txt | 36 +-
doc/add_key_info.1 | 4 +-
doc/api.txt | 4 +-
doc/asn_gen.1 | 1692 ++++++++++----------
doc/caselist.txt | 384 ++---
doc/casn_functions.3 | 68 +-
doc/check_signature.1 | 7 +-
doc/db_schema_requirements.txt | 32 +-
doc/doxygen/DoxygenLayout.xml | 4 +-
doc/doxygen/README | 9 +-
doc/doxygen/customdoxygen.css | 545 ++++---
doc/doxygen/navtree.css | 5 +-
doc/dump.1 | 172 +-
doc/gen_key.1 | 2 +-
doc/glossary.txt | 3 +-
doc/make_manifest.1 | 32 +-
doc/make_roa.1 | 18 +-
doc/privateTAdesign.txt | 72 +-
doc/read_roa.1 | 20 +-
doc/rpki-rtr-daemon-outline | 4 +-
doc/rr.1 | 378 +++--
doc/rsync_aur.1 | 49 +-
doc/rsync_aur.txt | 172 +-
doc/sign_cert.1 | 4 +-
doc/testbed.txt | 10 +-
doc/testplan_local_trust_anchor_mgmt.txt | 183 ++-
lib/casn/asn.c | 12 +-
lib/casn/asn.h | 16 +-
lib/casn/asn_error.h | 10 -
lib/casn/asn_flags.h | 36 +-
lib/casn/asn_gen/asn.h | 8 +-
lib/casn/asn_gen/asn_flags.h | 12 +-
lib/casn/asn_gen/asn_gen.c | 38 +-
lib/casn/asn_gen/asn_gen.h | 16 +-
lib/casn/asn_gen/asn_obj.h | 14 +-
lib/casn/asn_gen/asn_pproc.c | 23 +-
lib/casn/asn_gen/asn_pprocx.c | 63 +-
lib/casn/asn_gen/asn_read.c | 181 +--
lib/casn/asn_gen/asn_tabulate.c | 73 +-
lib/casn/asn_gen/asn_timedefs.h | 6 -
lib/casn/asn_gen/casn_constr.c | 31 +-
lib/casn/asn_gen/casn_hdr.c | 37 +-
lib/casn/casn.c | 22 +-
lib/casn/casn.h | 3 -
lib/casn/casn_bit.c | 4 -
lib/casn/casn_bits.c | 6 -
lib/casn/casn_copy_diff.c | 6 -
lib/casn/casn_dump.c | 13 +-
lib/casn/casn_error.c | 4 -
lib/casn/casn_file_ops.c | 6 -
lib/casn/casn_num.c | 4 -
lib/casn/casn_objid.c | 4 -
lib/casn/casn_other.c | 4 -
lib/casn/casn_real.c | 22 +-
lib/casn/casn_time.c | 14 +-
lib/config/config.c | 16 +-
lib/configlib/config_load.c | 179 ++-
lib/configlib/configlib.c | 9 +-
lib/configlib/configlib.h | 6 +-
lib/configlib/configlib_type.h | 8 +-
lib/configlib/types/bool.c | 4 +-
lib/configlib/types/enum.c | 4 +-
lib/configlib/types/path.c | 4 +-
lib/configlib/types/sscanf.c | 3 +-
lib/db/clients/chaser.c | 5 +-
lib/db/clients/chaser.h | 2 +
lib/db/clients/rtr.c | 5 +-
lib/db/connect.c | 3 +-
lib/db/prep-stmt.c | 5 +-
lib/db/prep-stmt.h | 1 +
lib/db/util.c | 3 +-
lib/rpki-asn1/Algorithms.asn | 121 +-
lib/rpki-asn1/blob.asn | 4 +-
lib/rpki-asn1/certificate.asn | 101 +-
lib/rpki-asn1/crlv2.asn | 26 +-
lib/rpki-asn1/extensions.asn | 193 +--
lib/rpki-asn1/keyfile.asn | 4 +-
lib/rpki-asn1/manifest.asn | 5 +-
lib/rpki-asn1/name.asn | 28 +-
lib/rpki-asn1/orname.asn | 6 -
lib/rpki-asn1/privkey.asn | 4 -
lib/rpki-asn1/serial_number.asn | 11 +-
lib/rpki-object/certificate.c | 9 +-
lib/rpki-object/cms/cms.c | 10 +-
lib/rpki-object/crl.c | 4 +-
lib/rpki-object/signature.c | 10 +-
lib/rpki-rtr/pdu.c | 220 +--
lib/rpki-rtr/pdu.h | 57 +-
lib/rpki/cms/roa_create.c | 7 +-
lib/rpki/cms/roa_general.c | 5 -
lib/rpki/cms/roa_serialize.c | 79 +-
lib/rpki/cms/roa_utils.h | 77 +-
lib/rpki/cms/roa_validate.c | 67 +-
lib/rpki/conversion.c | 12 +-
lib/rpki/conversion.h | 49 -
lib/rpki/db_constants.h | 8 +-
lib/rpki/diru.c | 23 +-
lib/rpki/diru.h | 7 +-
lib/rpki/err.c | 4 +-
lib/rpki/err.h | 6 +-
lib/rpki/globals.h | 26 +-
lib/rpki/initscm.c | 24 +-
lib/rpki/myssl.c | 150 +-
lib/rpki/myssl.h | 30 +-
lib/rpki/querySupport.c | 161 +-
lib/rpki/querySupport.h | 103 +-
lib/rpki/rpcommon.c | 22 +-
lib/rpki/rpwork.c | 77 +-
lib/rpki/rpwork.h | 4 -
lib/rpki/scm.h | 13 +-
lib/rpki/scmf.h | 167 +-
lib/rpki/scmmain.h | 33 +-
lib/rpki/sqcon.c | 211 +--
lib/rpki/sqhl.c | 123 +-
lib/rpki/sqhl.h | 17 +-
lib/rpki/tests/roa_test/roa_test.c | 5 -
lib/rpki/tests/test_check_sig.c | 4 -
lib/rpki/tests/test_val2.c | 4 -
lib/util/bag.c | 24 +-
lib/util/cryptlib_compat.c | 4 +-
lib/util/file.c | 4 +-
lib/util/hashutils.c | 4 +-
lib/util/hashutils.h | 2 +
lib/util/inet.c | 4 +-
lib/util/macros.h | 14 +-
lib/util/path_compat.c | 4 +-
lib/util/queue.c | 52 +-
lib/util/queue.h | 44 +-
lib/util/semaphore_compat.c | 16 +-
lib/util/stringutils.h | 5 +-
mk/libcasn.mk | 2 -
mk/librpki.mk | 1 -
mk/rpki-rtr.mk | 2 +-
mk/rpki.mk | 2 +-
tests/conformance/rfc3779/Instructions | 19 +-
tests/conformance/rfc3779/README | 8 +-
tests/conformance/rfc3779/convert_tc.py.in | 54 +-
tests/conformance/rfc3779/convert_tc.py.readme | 52 +-
tests/conformance/scripts/gen_child_ca.sh.in | 54 +-
tests/subsystem/rpki-asn1/test_casn_random.c | 24 +-
.../subsystem/rpki-asn1/test_casn_random_driver.sh | 32 +-
.../rpki-local-ta/runSubsystemTest4.sh.in | 8 +-
tests/subsystem/rpki-local-ta/ttest4.1.par | 8 +-
tests/subsystem/rpki-local-ta/ttest4.2.par | 8 +-
tests/subsystem/testcases/README | 5 +-
tests/subsystem/testcases/cert_validate.c | 9 +-
tests/subsystem/testcases/gen_test_key.c | 6 +-
tests/subsystem/testcases/make_test_cert.c | 17 +-
tests/subsystem/testcases/make_test_crl.c | 11 +-
tests/subsystem/testcases/make_test_manifest.c | 15 +-
tests/subsystem/testcases/make_test_roa.c | 4 -
tests/subsystem/testcases/makekeys.in | 2 +-
tests/subsystem/testcases/print-cert-addrs.sh | 2 +-
tests/subsystem/testcases/tools/create_cert.py.in | 28 +-
tests/subsystem/testcases/tools/run_tc.py.in | 28 +-
tests/subsystem/testcases/tools/test.conf | 87 +-
tests/system/testDriver/.classpath | 14 +-
tests/system/testDriver/.project | 34 +-
.../.settings/org.eclipse.jdt.core.prefs | 50 +-
.../testDriver/.settings/org.eclipse.jdt.ui.prefs | 110 +-
tests/system/testDriver/model.xml | 19 +-
.../testDriver/src/com/bbn/rpki/test/Doc.txt | 72 +-
.../testDriver/src/com/bbn/rpki/test/TestMain.java | 326 ++--
.../com/bbn/rpki/test/execute/TaskExecutor.java | 32 +-
.../com/bbn/rpki/test/model/ArgDescription.java | 168 +-
.../bbn/rpki/test/model/DependencyDescription.java | 35 +-
.../com/bbn/rpki/test/model/TaskDescription.java | 292 ++--
.../src/com/bbn/rpki/test/model/TestModel.java | 220 +--
.../src/com/bbn/rpki/test/model/XMLBase.java | 54 +-
.../bbn/rpki/test/ui/ArgDescriptionsEditor.java | 351 ++--
.../src/com/bbn/rpki/test/ui/PropertiesEditor.java | 272 ++--
.../bbn/rpki/test/ui/TaskDescriptionEditor.java | 294 ++--
.../bbn/rpki/test/ui/TaskDescriptionsEditor.java | 224 +--
.../src/com/bbn/rpki/test/ui/TextFileViewer.java | 86 +-
tests/system/testbed/src/certs.conf | 2 +-
tests/system/testbed/src/create_objects.py.in | 150 +-
tests/system/testbed/src/generic_allocate.py.in | 2 +-
tests/system/testbed/src/rpkirepo.py.in | 62 +-
tests/system/testbed/src/testbed_create.py.in | 33 +-
tests/test.include.in | 20 +-
248 files changed, 5736 insertions(+), 6183 deletions(-)
delete mode 100644 lib/rpki/conversion.h
--
2.4.5
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
rpstir-devel mailing list
rpstir-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/rpstir-devel
