Hi Kevin,

On Thu, Sep 25, 2008 at 08:44:38PM +0000, kevin brintnall wrote:
>  src/rrd_client.c |   47 ++++++++++++++++++++++++++++++++++++++++++-----

oh, I must have missed that, thanks for fixing it :)

> -static int rrdc_connect_network (const char *addr) /* {{{ */
> +static int rrdc_connect_network (const char *addr_orig) /* {{{ */
>  {
> +  char addr_copy[NI_MAXHOST];
> +  char *addr;

Forgot to mention this before: I'm copying the address here, because
later we do something like
  port = strchr (addr, ':');
  if (port != NULL)
    *port = 0;
So we will write into the buffer pointed to by `addr' although it is a
`const char *' - that's not nice.. Hence the copy ;)

Regards,
-octo
-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/

Attachment: signature.asc
Description: Digital signature

_______________________________________________
rrd-developers mailing list
[email protected]
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

Reply via email to