Hi Daniel, On Mon, Oct 13, 2008 at 04:23:02PM +0100, [EMAIL PROTECTED] wrote: > There are various functions in rrd_open.c (e.g. rrd_read, rrd_write) > that can be abstracted to do what is required. > > However, I notice that some other files (e.g. rrd_create.c) also have > code which accesses files directly (e.g. calling open() to create a > file).
Imho, the currently existing code need _a_ _lot_ more abstraction in that respect. Having to mess around with the internal structure of RRD files in many places imho makes the code really hard to read and maintain. > Is there some ongoing work to centralise the file access code? Would it > be worthwhile for me to patch some of this code (e.g. rrd_create.c) to > go through the functions in rrd_open.c, or is there some other solution > coming? Please note that there was some discussion about a new API which started in the thread around "rrdtool 1.4 development ready to go" [1]. There have been no specific suggestions so far but I know that there are a couple of ideas floating around out there. I might make sense to not put too much effort into any modifications at this point but rather come up with a good solution for the API first. Cheers, Sebastian [1] https://lists.oetiker.ch/pipermail/rrd-developers/2008-September/002425.html -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
_______________________________________________ rrd-developers mailing list [email protected] https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers
