Hi Daniel,

I haven't looked at your patch in detail, but when I skimmed through it,
I noticed the following:

On Mon, Oct 13, 2008 at 11:36:13PM +0100, Daniel Pocock wrote:
> --- src/rrd_create.c  (revision 1598)
> +++ src/rrd_create.c  (working copy)
[...]
> -#if defined(_WIN32) && !defined(__CYGWIN__) && !defined(__CYGWIN32__)
> -    flags |= O_BINARY;
> -#endif

Why did you remove that? Afaik, that's required on windows - it has just
been added in r1423.

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

Attachment: signature.asc
Description: Digital signature

_______________________________________________
rrd-developers mailing list
[email protected]
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers

Reply via email to