On Fri, 2013-08-16 at 09:08 +0200, Tobias Oetiker wrote:
> Hi Svante,
>
> Yesterday Svante Signell wrote:
>
> > Hello,
> >
> > Attached is an updated Debian patch for 1.4.7-2, from 2009, to avoid
> > PATH_MAX problems for GNU/Hurd in rrd_graph.{c,h} and rrd_tool.c. This
> > patch is conditioned on if MAXPATH (and __GLIBC__) is defined or not.
> >
> > I would suggest to avoid PATH_MAX (MAXPATH) if possible to maximize
> > portability and reduce code cluttering. Depending on your decision, the
> > rest of my patches will be conditioned on PATH_MAX or not (there are
> > also a number of other Debian patches pending).
>
> that patch looks pretty neat I think ...
>
> would you integrate it in your upcoming patch ?
So you wan one megapatch for PATH_MAX/MAXPATH issues? Isn't it better to
create smaller patches that can easily be reverted if something goes
wrong?
Another issue is if code should be #ifdef-ed or unconditional, e.g.
using
#ifdef MAX_PATH or
#ifndef MAX_PATH
...
#else
...
#endif
or completely removing the PATH_MAX (MAXPATH) dependency. What about the
Win32 port? I haven't looked into that.
Thanks,
Svante
_______________________________________________
rrd-developers mailing list
[email protected]
https://lists.oetiker.ch/cgi-bin/listinfo/rrd-developers
