On Thu, Apr 23, 2009 at 3:59 PM, Mark Wilden <[email protected]> wrote:
> On Thu, Apr 23, 2009 at 12:05 PM, James Byrne <[email protected]> wrote:
>
>> When /currency exchange rate transfer file should contain rates/ do
>> found = false
>> fx_code = 'USD'
>> File.open(FOREX_XFR_FN).each do |line|
>> found = true if
>> /.*fx_target#{fx_code}.*fx_rate(\d+\.\d{4}).*/.match(line)
>> break if found
>> end
>> fail(ArgumentError, "Exchange Rate not found for #{fx_code}") if not
>> found
>> end
>
> I find this more straighforward and easy to understand:
>
> When /currency exchange rate transfer file should contain rates/ do
> fx_code = 'USD'
> File.open(FOREX_XFR_FN).each do |line|
> return true if
> /.*fx_target#{fx_code}.*fx_rate(\d+\.\d{4}).*/.match(line)
> end
> fail(ArgumentError, "Exchange Rate not found for #{fx_code}")
> end
I'd even vote for the more concise form:
When /currency exchange rate transfer file should contain rates/ do
fx_code = 'USD'
IO.readlines(FOREX_XFR_FN).any?{ |line|
line.match /.*fx_target#{fx_code}.*fx_rate(\d+\.\d{4}).*/
} || fail ArgumentError, "Exchange Rate not found for #{fx_code}" unless found
end
>
> ///ark
>
> _______________________________________________
> rspec-users mailing list
> [email protected]
> http://rubyforge.org/mailman/listinfo/rspec-users
>
--
Zach Dennis
http://www.continuousthinking.com (personal)
http://www.mutuallyhuman.com (hire me)
@zachdennis (twitter)
_______________________________________________
rspec-users mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/rspec-users
