I have to fix an issue in the mandriva rpm of rsync. On the build computer, 
both nobody and nogroup exists but the right group to use is 'nogroup' [1].

The rsync configure.ac first check if 'nobody' group exists, which is true.

You can't change the current check, there is no perfect way to please to 
everybody, and I thing "nobody" group is more common.

Then to fix the issue I patch configure.ac to have a --with-nobody-group which 
allow to bypass the automatic detection and directly set the "nobody" group.

Any chance to have it apply for next rsync version ? Patch over cvs attached.

[1] The report: http://qa.mandriva.com/show_bug.cgi?id=21340
? acls.c
? smb_acls.h
? lib/sysacls.c
? lib/sysacls.h
? testsuite/default-acls.test
Index: configure.in
===================================================================
RCS file: /cvsroot/rsync/configure.in,v
retrieving revision 1.249
diff -u -b -B -w -p -r1.249 configure.in
--- configure.in	24 Apr 2006 22:24:40 -0000	1.249
+++ configure.in	16 Jun 2006 21:06:35 -0000
@@ -123,6 +123,11 @@ else
 fi
 AC_DEFINE_UNQUOTED(RSYNC_RSH, "$RSYNC_RSH", [default -e command])
 
+AC_ARG_WITH(nobody-group,
+    AC_HELP_STRING([--with-nobody-group=NOBODY_GROUP], [set the default unprivileged group (nobody)]),
+    [ NOBODY_GROUP="$with_nobody_group" ])
+
+if test x"$with_nobody_group" = x; then
 AC_MSG_CHECKING([the group for user "nobody"])
 if grep '^nobody:' /etc/group >/dev/null 2>&1; then
     NOBODY_GROUP=nobody
@@ -131,6 +136,8 @@ elif grep '^nogroup:' /etc/group >/dev/n
 else
     NOBODY_GROUP=nobody # test for others?
 fi
+fi
+
 AC_MSG_RESULT($NOBODY_GROUP)
 AC_DEFINE_UNQUOTED(NOBODY_USER, "nobody", [unprivileged user--e.g. nobody])
 AC_DEFINE_UNQUOTED(NOBODY_GROUP, "$NOBODY_GROUP", [unprivileged group for unprivileged user])

Attachment: pgpMow2lr70jb.pgp
Description: PGP signature

-- 
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Reply via email to