Rainer, thanks for integrating it and thanks for fixing the things I've overlooked.
I've skimmed through the commit logs and the changes look good, I'll run some more tests with the new sources. Regarding howmany(), it is defined here in my environment: /usr/include/sys/param.h: # define howmany(x, y) (((x) + ((y) - 1)) / (y)) It computes the number of 'y's needed to store 'x'. Tomas On 11/17/2009 10:49 AM, Rainer Gerhards wrote: > OK, I have finally integrated the patch, I could work around my missing > knowledge of howmany() [but still would appreciate some more info on it]. > > As of rsyslog policy, new features are never integrated into stable or beta > builds. As such, it is available in the v4-devel and master branches. Note > that I made a number of changes, you will probably like to re-check for your > use case. I ran the testbench successfully in both modes and did some manual > tests with the new functionality disabled. > > The v5-branch does NOT include the patch for imudp. As you said, it is a > (good ;)) work-around and imudp already supports epoll(), so there is no need > for this workaround. I plan to gradually remove that feature in v5 a I work > towards supporting epoll in all inputs. > > The master branch will probably be released tomorrow, v4-devel as need arises > (but it is available from git right now). > > Thanks again, I think this is a very useful addition. > > Rainer > >> -----Original Message----- >> From: [email protected] [mailto:rsyslog- >> [email protected]] On Behalf Of Rainer Gerhards >> Sent: Tuesday, November 17, 2009 10:01 AM >> To: rsyslog-users >> Subject: Re: [rsyslog] support for arbitrary number of open files >> >> Tomas, >> >> I am currently working on integration of this patch. What puzzles me is >> the >> call to "howmany()". I don't find any doc on it, nor an implementation >> inside >> the patch. Could you elaborate what it does and where it stems from? >> >> Also, I think there is a segfault in gss-misc, because the glbl >> interface is >> never aquired (the will result in a NULL-pointer dereference). I also >> need to >> change the glbl interface definitions, FdSetSize must always be >> present, else >> the interface is no longer well-defined. I will post the completely >> integrated patch when I am done. >> >> But feedback on howmany() would be most appreciated, because I >> currently do >> not know exactly how to handle it. >> >> Thanks, >> Rainer >> >>> -----Original Message----- >>> From: [email protected] [mailto:rsyslog- >>> [email protected]] On Behalf Of Tomas Heinrich >>> Sent: Monday, November 16, 2009 5:25 PM >>> To: rsyslog-users >>> Subject: [rsyslog] support for arbitrary number of open files >>> >>> Hi all, >>> >>> currently the total number of files (and tcp connections) that can be >>> open simultaneously is limited by the select() system call. Ideally >>> this >>> would be changed to *poll(), but that can take some time. >>> >>> Until that happens, this patch[1] tries to remove the limitations of >>> select() by enlarging the bit mask that is used for storing file >>> descriptor information and redefining the macros that process it. >>> This modification is inspired by Bind's use of select(). >>> It is rather a workaround and may not be entirely portable. >>> >>> The actual changes to the code aren't big, but they are in many >> places >>> so sufficient testing is needed. Allocating and freeing fd_sets in >>> some >>> frequently called functions may decrease performance. This can be >> dealt >>> with but would require more pervasive changes. >>> >>> Thoughts? >>> >>> Thanks, >>> Tomas >>> >>> [1] - http://people.redhat.com/pvrabec/rsyslog-4.4.2-unlimited- >>> select.patch >>> _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com
