OK, once the problematic spot is found, a fix is not far away...

The (very small) patch is self-explanatory, please see:

http://git.adiscon.com/?p=rsyslog.git;a=commitdiff;h=bab3ee566c883ac88df369ec
32df0c9100f97343

I've run it through a couple of tests now, and both theory and practice seem
to agree that this was the bug. 

Michael,
I'd appreciate if you could check if this solves the issue for you as well.

Thanks,
Rainer

> -----Original Message-----
> From: [email protected] [mailto:rsyslog-
> [email protected]] On Behalf Of Rainer Gerhards
> Sent: Tuesday, January 26, 2010 4:45 PM
> To: rsyslog-users
> Subject: Re: [rsyslog] rsyslog v5 crash on Debian sid - was:RE:
> rsyslog5.3.6(v5-beta) released
> 
> An update: this bug is *not* related to debian, but requires certain
> compiler
> settings. I now also get it on Fedora. Also, it has nothing to do with
> the
> named pipe. In fact, there seems to be a problem with the way direct
> queues
> are handled. I don't have full details yet, but finally I begin to
> understand
> the issue. It is a v5-only bug, introduced by the new queue engine.
> Direct
> queues (at least action queues) can cause a segfault, at least if
> something
> goes wrong in the action. Will post more details and/or a fix when I
> have
> better info.
> 
> Rainer
> 
> > -----Original Message-----
> > From: [email protected] [mailto:rsyslog-
> > [email protected]] On Behalf Of Rainer Gerhards
> > Sent: Monday, January 25, 2010 2:39 PM
> > To: rsyslog-users
> > Subject: [rsyslog] rsyslog v5 crash on Debian sid - was:RE: rsyslog
> > 5.3.6(v5-beta) released
> >
> > Hi Michael,
> >
> > finally, good news: I finally managed to reproduce the problem under
> > 32-bit
> > Debian sid. It looks like only v5 is affected, and not the quite
> > similar
> > v4-beta. I will now try to pinpoint the problem (hoping that the
> repro
> > is
> > stable).
> >
> > Will post more news when I have it.
> >
> > Rainer
> >
> > > -----Original Message-----
> > > From: [email protected] [mailto:rsyslog-
> > > [email protected]] On Behalf Of Michael Biebl
> > > Sent: Sunday, January 17, 2010 12:52 PM
> > > To: rsyslog-users
> > > Subject: Re: [rsyslog] rsyslog 5.3.6 (v5-beta) released
> > >
> > > 2010/1/17 Michael Biebl <[email protected]>:
> > > > 2010/1/17 Rainer Gerhards <[email protected]>:
> > > >>> -----Original Message-----
> > > >>> From: [email protected] [mailto:rsyslog-
> > > >>> [email protected]] On Behalf Of Michael Biebl
> > > >>> Sent: Friday, January 15, 2010 11:57 PM
> > > >>> To: rsyslog-users
> > > >>> Subject: Re: [rsyslog] rsyslog 5.3.6 (v5-beta) released
> > > >>>
> > > >>> 2010/1/15 Rainer Gerhards <[email protected]>:
> > > >>> > Michael,
> > > >>> >
> > > >>> > Fix now in git, links at the bug tracker:
> > > >>> >
> > > >>> > http://bugzilla.adiscon.com/show_bug.cgi?id=169
> > > >>> >
> > > >>> > Please let me know if it works for you (the patch is a bit
> > > trickier
> > > >>> than it
> > > >>> > looks, so confirmations would be good).
> > > >>>
> > > >>> I applied 5b4e06fc28ef217e9ca26611e11afd974bdd1a4a on top of
> > 5.3.6.
> > > >>> But now I'm getting a crash when rsyslog encounters the
> xconsole
> > > pipe
> > > >>> config.
> > > >>
> > > >> I am a bit puzzled, but will try to reproduce that on my Debian
> > box.
> > > I assume
> > > >> stock Debian config?
> > > >
> > > > Yes. As said, I just downloaded the 5.3.6 tarball applied the
> > > > 5b4e06fc28ef217e9ca26611e11afd974bdd1a4a patch on top of it and
> > then
> > > > got the crash. I use the default rsyslog.conf from the official
> > > debian
> > > > package.
> > >
> > > As an additonal hint: If I start xconsole (a process reading from
> > > /dev/xconsole) before I start rsyslogd, then the crash does not
> > occur.
> > >
> > >
> > >
> > > --
> > > Why is it that all of the instruments seeking intelligent life in
> the
> > > universe are pointed away from Earth?
> > > _______________________________________________
> > > rsyslog mailing list
> > > http://lists.adiscon.net/mailman/listinfo/rsyslog
> > > http://www.rsyslog.com
> > _______________________________________________
> > rsyslog mailing list
> > http://lists.adiscon.net/mailman/listinfo/rsyslog
> > http://www.rsyslog.com
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com

Reply via email to