I just wanted to let you know that I have integrated the patch. Many thanks
for your effort!

Rainer

> -----Original Message-----
> From: [email protected] [mailto:rsyslog-
> [email protected]] On Behalf Of Steffen Sledz
> Sent: Friday, July 30, 2010 2:53 PM
> To: [email protected]
> Subject: [rsyslog] [PATCH] break potential infinite loop in
> actionDoRetry
> 
> If a module always returns RS_RET_OK (like ompipe does) the
> actionDoRetry
> loop may not have leaved faked ACT_STATE_SUSP state in case
> iResumeOKinRow
> had ever reached a count of 1000.
> 
> Signed-off-by: Steffen Sledz <[email protected]>
> ---
>  action.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/action.c b/action.c
> index 32a07dc..90ec1bf 100644
> --- a/action.c
> +++ b/action.c
> @@ -508,6 +508,7 @@ static rsRetVal actionDoRetry(action_t *pThis,
> time_t ttNow)
>               iRet = pThis->pMod->tryResume(pThis->pModData);
>               if((pThis->iResumeOKinRow > 999) && (pThis->iResumeOKinRow
> % 1000 == 0)) {
>                       bTreatOKasSusp = 1;
> +                     pThis->iResumeOKinRow = 0;
>               } else {
>                       bTreatOKasSusp = 0;
>               }
> --
> 1.6.4.2
> 
> _______________________________________________
> rsyslog mailing list
> http://lists.adiscon.net/mailman/listinfo/rsyslog
> http://www.rsyslog.com
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com

Reply via email to