Hi Rainer, I think old, inconsistent functionality shouldn't stand in the way of performance improvements. However, the backwards-incompatible change would break some configs. So maybe there's a nice way to change things.
How about deprecating imtcp and providing a new module with consistent hostname handling? Or, could rsyslog analyze the hostnames provided when parsing the config, and if they're uppercase, throw a warning message and lowercase them? Best regards, Radu 2013/1/22 Rainer Gerhards <[email protected]> > Hi all, > > while looking for optimization opportunities, I found that some imtcp > returns hostnames inconsistent with what the other modules do. In all > modules but imtcp, the hostname is normalized, that is converted to all > lower case. However, in imtcp this normalization is not done. > > I would like to combine the hostname handling, which also provides some > nice performance improvement opportunities (I can do more preprocessing > inside the cache module). However, this means we need to have a consistent > handling. As the vast majority of modules converts to lower case, I would > do that in all cases in the future. > > Questions now: > 1) Is converting hostnames to lower case a good choice? > 2) Do I break to much with this change? Aka: must the inconsistency be > preserved? > > Feedback appreciated. > > Thanks, > Rainer > _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
