On Tue, Sep 3, 2013 at 10:55 PM, Michael Biebl <[email protected]> wrote:
> 2013/9/3 Florian Riedl <[email protected]>: > > Hi all, > > > > We have just released 7.4.4 of the v7-stable branch. This is a pure > > bug-fixing release. More information on the changes can be found in the > > ChangeLog. > ... > > make rsyslog use the new json-c pkgconfig file if available > > Thanks to the Gentoo team for the patches. > > Looks like this doesn't yet work properly. rsyslog still uses > json/foo.h includes so it fails: > > msg.c:46:38: fatal error: json/json_object_private.h: No such file or > directory > #include <json/json_object_private.h> > ^ > > I guess, rsyslog should use the CFLAGS provided by json-c.pc and drop > the json/ prefix. > upstream renamed the include directory to /usr/include/json-c/ > > Afaics, the following files need to be fixed: > runtime/msg.c:#include <json/json_object_private.h> > plugins/ommongodb/ommongodb.c:#include <json/json_object_private.h> > > Thanks, it's fixed now. Will be part of 7.4.5. http://git.adiscon.com/?p=rsyslog.git;a=commitdiff;h=dd9bdb5566c56a2bb67b09a67410b16e29004568 > The files contain this comment: > /* For struct json_object_iter, should not be necessary in future versions > */ > > So maybe that include can be dropped now? > > well... maybe - but there are many platforms out there that only support the "ld" json-c version. So I guess this needs to be present for the next years to come. Rainer > Michael > _______________________________________________ > rsyslog mailing list > http://lists.adiscon.net/mailman/listinfo/rsyslog > http://www.rsyslog.com/professional-services/ > What's up with rsyslog? Follow https://twitter.com/rgerhards > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you > DON'T LIKE THAT. > _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
