2014-08-20 19:21 GMT+02:00 Michael Biebl <[email protected]>: > 2014-08-19 16:00 GMT+02:00 Rainer Gerhards <[email protected]>: >> On Tue, Aug 19, 2014 at 3:38 PM, Rainer Gerhards <[email protected]> >> wrote: >> >>> On Tue, Aug 19, 2014 at 3:18 PM, Michael Biebl <[email protected]> wrote: >>> >>>> 2014-08-19 14:53 GMT+02:00 Michael Biebl <[email protected]>: >>>> > >>>> > Reverting 6d668c915fdacbeea85348ba6b03958f8622e1a1 fixed the build on >>>> > the mips porterbox. >>>> >>>> Not surprisingly, it also fixes the build on sparc >>>> >>>> >>>> >>> yup, thx, this was a very good hint. I guess I looked at the wrong problem >>> area. Probably a missing semicolon somewhere. Will work my way through it >>> :-) >>> >>> yeah, got it. It's indeed semicolon trouble that you get as soon as you >> disable atomic instructions. Can now look in more depth for a proper fix. > > The changes to runtime/statsobj.h [1] look wrong. Re-adding the > missing ";" fixes the build > > > diff --git a/runtime/statsobj.h b/runtime/statsobj.h > index 347f639..d56485d 100644 > --- a/runtime/statsobj.h > +++ b/runtime/statsobj.h > @@ -139,7 +139,7 @@ PROTOTYPEObj(statsobj); > */ > #define STATSCOUNTER_DEF(ctr, mut) \ > intctr_t ctr; \ > - DEF_ATOMIC_HELPER_MUT64(mut) > + DEF_ATOMIC_HELPER_MUT64(mut); > > #define STATSCOUNTER_INIT(ctr, mut) \ > INIT_ATOMIC_HELPER_MUT64(mut); \ > -- > > [1] > http://git.adiscon.com/?p=rsyslog.git;a=blobdiff;f=runtime/statsobj.h;h=347f639f8d735c37b25a578da6ca659c0f8fa47a;hp=d56485de11f57f70e8af23001c3be989a1b6757a;hb=6d668c915fdacbeea85348ba6b03958f8622e1a1;hpb=e61d8a88d081c35a4c3a5778e1fb9d23339dffd5
fwiw, I found it a bit confusing that the ";" were shuffled around for some defines, but not all. E.g. you moved it for DEF_ATOMIC_HELPER_MUT, but not DEF_ATOMIC_HELPER_MUT64. This is where this bug resulted from. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
